chore: CLI launch internal CI by ko3n1g · Pull Request #3695 · NVIDIA/Megatron-LM

ko3n1g · 2026-03-04T10:05:22Z

What does this PR do ?

Adds a CLI tool that makes it easy to test a public GH against the internal CI. For more details, please check out the README.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]

Pre-checks

I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
I have added relevant unit tests
I have added relevant functional tests
I have added proper typing to my code Typing guidelines
I have added relevant documentation
I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label `Expert Review`

(Step 2): Collect the expert reviewers reviews

Attach the Expert Review label when your PR is ready for review.
GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

Add Final Review label
GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch

The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: oliver könig <okoenig@nvidia.com>

Phlip79 · 2026-03-04T17:47:05Z

tools/trigger_internal_ci.md

+**1. Add the internal GitLab as a git remote** (skip if you already have one configured):
+
+```bash
+git remote add gitlab git@<gitlab-hostname>:<namespace>/<project>.git


Isn't this the same for everyone?

Phlip79 · 2026-03-04T17:47:42Z

tools/trigger_internal_ci.md

@@ -0,0 +1,73 @@
+# trigger_internal_ci.py
+
+Pushes the current branch to the internal GitLab remote and triggers a CI


I would mention that this is only available to NVIDIA internal employees.

Phlip79 · 2026-03-04T17:47:53Z

tools/trigger_internal_ci.md

@@ -0,0 +1,73 @@
+# trigger_internal_ci.py


Suggested change

# trigger_internal_ci.py

# Trigger Internal CI

Phlip79 · 2026-03-04T17:49:11Z

tools/trigger_internal_ci.md

+
+Reach out to @mcore-ci in case you don't have access to the settings page.
+
+```bash


Maybe mention this should be added to ~/.bashrc?

ko3n1g · 2026-03-04T19:09:25Z

/claude review

ko3n1g · 2026-03-04T19:14:05Z

/claude review

ko3n1g · 2026-03-04T19:21:32Z

/claude review

claude · 2026-03-04T19:22:55Z

tools/trigger_internal_ci.md

+
+To check existing remotes: `git remote -v`


Missing prerequisite: users need to install python-gitlab before running the script. Without it they'll get ModuleNotFoundError: No module named 'gitlab'. Please add an install step:

Suggested change

To check existing remotes: `git remote -v`

**3. Install the required Python dependency:**

```bash

pip install python-gitlab

claude · 2026-03-04T19:23:01Z

tools/trigger_internal_ci.py

+    gitlab_hostname = get_gitlab_hostname(remote_url)
+
+    target_branch = f"{GITLAB_BRANCH_PREFIX}/{branch}"
+
+    git_push(args.gitlab_origin, target_branch, dry_run=args.dry_run)
+
+    pipeline_vars = {


FUNCTIONAL_TEST is never explicitly set in pipeline_vars, so the tool silently relies on the GitLab CI YAML default ("yes"). If that default ever changes, functional tests will stop running without any warning. Consider making it explicit:

Suggested change

gitlab_hostname = get_gitlab_hostname(remote_url)

target_branch = f"{GITLAB_BRANCH_PREFIX}/{branch}"

git_push(args.gitlab_origin, target_branch, dry_run=args.dry_run)

pipeline_vars = {

pipeline_vars = {

**PIPELINE_VARIABLES_FIXED,

"FUNCTIONAL_TEST": "yes",

"FUNCTIONAL_TEST_SCOPE": args.functional_test_scope,

"FUNCTIONAL_TEST_REPEAT": str(args.functional_test_repeat),

"FUNCTIONAL_TEST_CASES": args.functional_test_cases,

}

claude · 2026-03-04T19:23:05Z

tools/trigger_internal_ci.py

+
+
+if __name__ == "__main__":
+    main()


Missing newline at end of file.

claude · 2026-03-04T19:23:13Z

Code Review

Overall the tool is clean and well-structured. A few issues to address:

Bugs / logic gaps

FUNCTIONAL_TEST is never included in pipeline_vars, so the tool silently depends on the GitLab YAML default being "yes". This is fragile — explicitly pass "FUNCTIONAL_TEST": "yes" in the dict. (inline comment on trigger_internal_ci.py L151–157)

Missing documentation

The README has no step to install the python-gitlab dependency. Without it users immediately hit ModuleNotFoundError. Add pip install python-gitlab to the Prerequisites section. (inline comment on trigger_internal_ci.md L13–14)

Minor

trigger_internal_ci.py is missing a trailing newline at EOF.
In get_gitlab_hostname, the .split(":")[0] after urlparse(...).hostname is redundant — urlparse().hostname already strips the port — but it's harmless.

chore: CLI launch internal CI

1aee448

Signed-off-by: oliver könig <okoenig@nvidia.com>

svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 4, 2026

svcnvidia-nemo-ci requested a review from a team March 4, 2026 10:05

copy-pr-bot bot temporarily deployed to test March 4, 2026 10:06 Inactive

allow trigger pipelines

9ee9011

Signed-off-by: oliver könig <okoenig@nvidia.com>

ko3n1g requested a review from a team as a code owner March 4, 2026 10:21

finalize

0a3e5d0

Signed-off-by: oliver könig <okoenig@nvidia.com>

copy-pr-bot bot had a problem deploying to test March 4, 2026 10:23 Error

add README

d9e3ea6

Signed-off-by: oliver könig <okoenig@nvidia.com>

ko3n1g requested review from a team and Phlip79 March 4, 2026 10:27

copy-pr-bot bot had a problem deploying to test March 4, 2026 10:28 Error

add note regarding permissions

3f4689b

Signed-off-by: oliver könig <okoenig@nvidia.com>

copy-pr-bot bot temporarily deployed to test March 4, 2026 10:32 Inactive

Phlip79 approved these changes Mar 4, 2026

View reviewed changes

claude bot reviewed Mar 4, 2026

View reviewed changes

tools/trigger_internal_ci.py

if __name__ == "__main__":

main() No newline at end of file

Copy link

claude bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at end of file.

Phlip79 added the Expert Review Apply this label to indicate that your PR is ready for expert review. label Mar 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: CLI launch internal CI#3695

chore: CLI launch internal CI#3695
ko3n1g wants to merge 5 commits intoNVIDIA:mainfrom
ko3n1g:ko3n1g/chore/launch-internal-ci

ko3n1g commented Mar 4, 2026 •

edited

Loading

Uh oh!

Phlip79 Mar 4, 2026

Uh oh!

Phlip79 Mar 4, 2026

Uh oh!

Phlip79 Mar 4, 2026

Uh oh!

Phlip79 Mar 4, 2026

Uh oh!

ko3n1g commented Mar 4, 2026

Uh oh!

ko3n1g commented Mar 4, 2026

Uh oh!

ko3n1g commented Mar 4, 2026

Uh oh!

claude bot Mar 4, 2026

Uh oh!

claude bot Mar 4, 2026

Uh oh!

claude bot Mar 4, 2026

Uh oh!

claude bot commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,73 @@
		# trigger_internal_ci.py

		Pushes the current branch to the internal GitLab remote and triggers a CI


		Reach out to @mcore-ci in case you don't have access to the settings page.

		```bash

-To check existing remotes: `git remote -v`
+**3. Install the required Python dependency:**
+```bash
+pip install python-gitlab

Conversation

ko3n1g commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do ?

Contribution process

Pre-checks

Code review

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

(Step 3): Final Review

(Optional Step 4): Cherry-pick into release branch

Merging your PR

Uh oh!

Phlip79 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Phlip79 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Phlip79 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Phlip79 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

ko3n1g commented Mar 4, 2026

Uh oh!

ko3n1g commented Mar 4, 2026

Uh oh!

ko3n1g commented Mar 4, 2026

Uh oh!

claude bot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot commented Mar 4, 2026

Code Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ko3n1g commented Mar 4, 2026 •

edited

Loading

(Step 1): Add PR label `Expert Review`